Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ocpcluster masters #236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename ocpcluster masters #236

wants to merge 1 commit into from

Conversation

bn222
Copy link
Contributor

@bn222 bn222 commented Dec 27, 2024

testing if CI works again

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2024
@bn222
Copy link
Contributor Author

bn222 commented Dec 27, 2024

/test make-e2e-test

1 similar comment
@bn222
Copy link
Contributor Author

bn222 commented Dec 27, 2024

/test make-e2e-test

@bn222
Copy link
Contributor Author

bn222 commented Dec 27, 2024

/test make-test

3 similar comments
@wizhaoredhat
Copy link
Contributor

/test make-test

@vrindle
Copy link
Contributor

vrindle commented Dec 27, 2024

/test make-test

@vrindle
Copy link
Contributor

vrindle commented Dec 27, 2024

/test make-test

@bn222
Copy link
Contributor Author

bn222 commented Jan 2, 2025

@vrindle can you make this pass?

@bn222
Copy link
Contributor Author

bn222 commented Jan 2, 2025

/test make-e2e-test

@bn222
Copy link
Contributor Author

bn222 commented Jan 6, 2025

/hold

Waiting for @vrindle to make sure our ci runs the necessary tests automatically

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2025
@bn222
Copy link
Contributor Author

bn222 commented Jan 6, 2025

/retest

@bn222
Copy link
Contributor Author

bn222 commented Jan 8, 2025

/test make-e2e-test

@bn222
Rename ocpcluster masters
1c5c20c 
Signed-off-by: Balazs Nemeth <[email protected]>
@bn222
Copy link
Contributor Author

bn222 commented Jan 8, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 8, 2025

@bn222: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/make-e2e-test 1c5c20c link true /test make-e2e-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thom311 thom311 thom311 left review comments

@SalDaniele SalDaniele Awaiting requested review from SalDaniele

@wizhaoredhat wizhaoredhat Awaiting requested review from wizhaoredhat

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bn222 @wizhaoredhat @vrindle @thom311